Repository navigation
Bound automatic diagonal heuristics by two cardinal steps - #198
Merged
HexDecimal merged 3 commits intoOct 17, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #198 +/- ##
=======================================
Coverage 86.09% 86.09%
=======================================
Files 29 29
Lines 7597 7597
=======================================
Hits 6541 6541
Misses 1056 1056 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
HexDecimal
approved these changes
Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SimpleGraphcan overestimate the remaining cost when a diagonal costs more than two cardinal steps. On the regression's unit-cost map, cardinal cost 1 and diagonal cost 3 return a cost-9 path although eight cardinal steps suffice.Cap the automatic diagonal estimate at two cardinal steps. Keep the actual diagonal edge cost, diagonal-only graphs, greed multiplier and explicit heuristic overrides.
The regressions cover C/F layouts and diagonal-only movement. An independent sample-dungeon heap oracle confirms all 60 previously incorrect single-endpoint queries, with all 1,920 ordinary-cost controls unchanged. A separate many-to-many reconstruction correction handles the remaining 59 failures; both together match all 2,240 queries.
Full headless tests pass (324 passed, 95 skipped), using pinned native resource assets and SDL dummy audio. Mypy and applicable project formatting/hooks pass.